Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-48244: ztp: ci check to ensure source-cr filenames are within 255 limit #2185

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

abraham2512
Copy link
Member

@abraham2512 abraham2512 commented Jan 28, 2025

This PR adds a CI check in ztp/ to ensure files in the source-crs directory are within 255 character limit.

/cc @irinamihai @sabbir-47

@openshift-ci openshift-ci bot requested review from simon3z and Tal-or January 28, 2025 20:47
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abraham2512
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abraham2512 abraham2512 changed the title ztp: ci check to ensure source-cr filenames are within 255 limit OCPBUGS-48244: ztp: ci check to ensure source-cr filenames are within 255 limit Jan 30, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 30, 2025
@openshift-ci-robot
Copy link
Collaborator

@abraham2512: This pull request references Jira Issue OCPBUGS-48244, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR adds a CI check in ztp/ to ensure files in the source-crs directory are within 255 character limit.

/cc @irinamihai @sabbir-47

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 30, 2025
ztp/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

@abraham2512: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ran-profile c50c3ca link false /test e2e-aws-ran-profile

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants