Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaborated instructions for branching #2168

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rbaturov
Copy link
Contributor

We've recently faced issues due to misaligned cnf-tests container images. Since it's easy to forget updating the image version across the repo, these changes to the branching guide are necessary to cover (hopefully) all required updates when creating a new release branch. The intention is for anyone creating the release-x.y branch to follow this, minimizing the chances of misalignments. Additionally, we plan to implement automation in the CI that will trigger a failure if these instructions are not followed.

Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2025
Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbaturov
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rbaturov
Copy link
Contributor Author

Depends on:
#2167
#2169

We've recently faced issues due to misaligned cnf-tests container images.
Since it's easy to forget updating the image version across the repo, these changes to the branching guide are necessary to cover (hopefully) all required updates when creating a new release branch.
The intention is for anyone creating the release-x.y branch to follow this, minimizing the chances of misalignments.
Additionally, we plan to implement automation in the CI that will trigger a failure if these instructions are not followed.

Signed-off-by: Ronny Baturov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant