-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase retry timeout when polling CI run result #423
Merged
komish
merged 1 commit into
openshift-helm-charts:main
from
mgoerens:increase_retry_timeout
Jan 20, 2025
Merged
Increase retry timeout when polling CI run result #423
komish
merged 1 commit into
openshift-helm-charts:main
from
mgoerens:increase_retry_timeout
Jan 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During end to end tests, we query the GitHub API regularly to check if the pipeline associated with the test PR has completed. This commit increase the retry timeout in order to decrease the total amount of API calls that the bot account is performing. This helps with staying within the GitHub API rate limits as highlighted in openshift-helm-charts#422. Signed-off-by: Matthias Goerens <[email protected]>
This was referenced Jan 20, 2025
komish
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During end to end tests, we query the GitHub API regularly to check if the pipeline associated with the test PR has completed. This commit increase the retry timeout in order to decrease the total amount of API calls that the bot account is performing. This helps with staying within the GitHub API rate limits as highlighted in #422.