fix missing RELEASE_TAG value for index update commits #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose R. Gonzalez <[email protected]>
This was referenced Nov 6, 2024
This was referenced Nov 6, 2024
|
How did this come to not working ? What changed ? |
|
@mgoerens the value was previously calculated in-script, vs. being passed in as an environment variable. When the shell script was introduced (replacing the python script that preceded it), the environment variable wasn't added to the task, but empty vars by default are not an error in Bash, so it was quietly "failing". |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index update commit messages no longer have the chart's release information (i.e. org-chartname-version). This is because there is data not being transferred across jobs in the certification workflow.
The
RELEASE_TAGenvironment variable is used in this script, but has no value assigned to it. It's being set in a previous job, so we can easily pass along this variable to this script.