Fix date of next community meeting #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
requested review from
elfisher,
AMoo-Miki,
nknize,
krisfreedain,
peterzhuamazon,
CEHENKLE,
dtaivpp,
kolchfa-aws and
nateynateynate
as code owners
In my time zone, the website says "Date: 14/11/2023 Time: 12:00:00", on meetup, I see "Tuesday, November 14, 2023 at 1:00 PM to Tuesday, November 14, 2023 at 2:00 PM UTC−10". Looks-like the TZ offset is not the good one. Signed-off-by: Romain Tartière <[email protected]>
smortex
force-pushed
the
fix-next-community-meeting-date
branch
from
c835186 to
4672f85
Compare
1 task
smortex
added a commit
to smortex/project-website
that referenced
this pull request
Nov 28, 2023
We have a track record of Time-Zone inconsistencies in the events of the project website (e.g. opensearch-project#1616, opensearch-project#1805, opensearch-project#2288, opensearch-project#2418, opensearch-project#2422, opensearch-project#2431, opensearch-project#2449). In order to detect these inconsistencies earlier, make the `tz` mandatory and check that the Time-Zone offset match the Time-Zone name. These checks require a working bundle so run it on GitHub actions and keep the old pre-commit check to only check date formatting using basic UNIX tooling. Adjust the events templates to match what we expect. While here, also check that non-online events have the needed `location.city` and `location.country`. Signed-off-by: Romain Tartière <[email protected]>
smortex
added a commit
to smortex/project-website
that referenced
this pull request
Nov 28, 2023
We have a track record of Time-Zone inconsistencies in the events of the project website (e.g. opensearch-project#1616, opensearch-project#1805, opensearch-project#2288, opensearch-project#2418, opensearch-project#2422, opensearch-project#2431, opensearch-project#2449). In order to detect these inconsistencies earlier, make the `tz` mandatory and check that the Time-Zone offset match the Time-Zone name. These checks require a working bundle so run it on GitHub actions and keep the old pre-commit check to only check date formatting using basic UNIX tooling. Adjust the events templates to match what we expect. While here, also check that non-online events have the needed `location.city` and `location.country`. Signed-off-by: Romain Tartière <[email protected]>
smortex
added a commit
to smortex/project-website
that referenced
this pull request
Mar 13, 2024
We have a track record of Time-Zone inconsistencies in the events of the project website (e.g. opensearch-project#1616, opensearch-project#1805, opensearch-project#2288, opensearch-project#2418, opensearch-project#2422, opensearch-project#2431, opensearch-project#2449). In order to detect these inconsistencies earlier, make the `tz` mandatory and check that the Time-Zone offset match the Time-Zone name. These checks require a working bundle so run it on GitHub actions and keep the old pre-commit check to only check date formatting using basic UNIX tooling. Adjust the events templates to match what we expect. While here, also check that non-online events have the needed `location.city` and `location.country`. Signed-off-by: Romain Tartière <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my time zone, the website says "Date: 14/11/2023 Time: 12:00:00", on
meetup, I see "Tuesday, November 14, 2023 at 1:00 PM to Tuesday,
November 14, 2023 at 2:00 PM UTC−10". Looks-like the TZ offset is not
the good one.