Enhance Session Job Handling and Heartbeat Mechanism #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces two key improvements: 1. An initial delay is added to start the heartbeat mechanism, reducing the risk of concurrent update conflicts. 2. The 'jobId' in the session store is updated at the beginning to properly manage and evict old jobs for the same session. Testing Performed: 1. Manual sanity testing was conducted. 2. It was ensured that old jobs eventually exit after a new job for the same session starts. 3. The functionality of the heartbeat mechanism was verified to still work effectively. Signed-off-by: Kaituo Li <[email protected]>
kaituo
requested review from
dai-chen,
rupal-bq,
vamsimanohar,
penghuo,
anirudha and
YANG-DB
as code owners
penghuo
reviewed
Nov 18, 2023
flint-spark-integration/src/main/scala/org/opensearch/flint/app/FlintInstance.scala
Show resolved
Hide resolved
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintREPL.scala
Outdated
Show resolved
Hide resolved
…s does not contain currentJobId. Signed-off-by: Kaituo Li <[email protected]>
|
format code using |
Signed-off-by: Kaituo Li <[email protected]>
formatted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces two key improvements:
Testing Performed:
Issues Resolved
#162
#159
#145
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.