Update to upload-artifact@v4

[seankao-az]

Description

CI is failing for

This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

[dai-chen]

Just wonder is all CI starting to fail today? I saw my PR merged yesterday succeeded.

[Swiddis]

is all CI starting to fail today?

This is the first of 3 scheduled brownouts https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/

[noCharger]

Thx for the change. I think SQL plugin also needs upgrade.

[seankao-az]

I think SQL plugin also needs upgrade.

SQL plugin already is using v4 as far as i know

[opensearch-trigger-bot]

The backport to 0.6 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.6 0.6
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.6
# Create a new branch
git switch --create backport/backport-1013-to-0.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e42c535b05843888658ad59e02d6cfd486f31e2e
# Push it to GitHub
git push --set-upstream origin backport/backport-1013-to-0.6
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.6

Then, create a pull request where the base branch is 0.6 and the compare/head branch is backport/backport-1013-to-0.6.

[noCharger]

I think SQL plugin also needs upgrade.

SQL plugin already is using v4 as far as i know

Not on 2.x https://github.com/opensearch-project/sql/blob/2.x/.github/workflows/integ-tests-with-security.yml#L50