Adding X-Forwarded-for header in httpd access_log when using port 80 and test case #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Lu <[email protected]>
jordarlu
changed the title
jordarlu
changed the title
jordarlu
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi and
Divyaasm
as code owners
Signed-off-by: Jeff Lu <[email protected]>
Signed-off-by: Jeff Lu <[email protected]>
prudhvigodithi
approved these changes
Mar 25, 2024
gaiksaya
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding X-Forwarded-for header in httpd access_log when using port 80 and test case
We prevesiousely add the X-Forwarded-for header on access_log when using port 443.
In this PR, we add it when using port 80 as well.
Along with the test case in ci-stack.test
Issues Resolved
By following up the #403 :
In #403, we added X-Forwarded-for header in httpd access_log when using port 443.
In this PR, we add the same but for the traffic using port 80 to cover all http cases.
And we also add test cases for both 80 and 443.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.