Update gcc to 12.4 to support avx512_fp16 in k-NN faiss lib and node20 on arm64 #5241
+35
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added
enhancement
Signed-off-by: Peter Zhu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5241 +/- ##
==========================================
- Coverage 92.35% 92.12% -0.24%
==========================================
Files 197 202 +5
Lines 6814 7033 +219
==========================================
+ Hits 6293 6479 +186
- Misses 521 554 +33 ☔ View full report in Codecov by Sentry. |
5 tasks
Signed-off-by: Peter Zhu <[email protected]>
63 tasks
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
rishabh6788
requested review from
dblock,
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
peterzhuamazon
changed the title
rishabh6788
reviewed
Jan 22, 2025
docker/ci/dockerfiles/current/build.al2.opensearch.x64.arm64.dockerfile
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Zhu <[email protected]>
rishabh6788
approved these changes
Jan 22, 2025
|
Building took way too long over 5 hours, would need to reduce the times on this. |
This was referenced Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update gcc to 12.4 to support avx512_fp16 in k-NN faiss lib and node20 on arm64
Issues Resolved
Closes #5226
Also follow up: #5178
Part of #5248
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.