Rename indices to indexes #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mansi Shinde <[email protected]>
Signed-off-by: Mansi Shinde <[email protected]>
MansiShinde
requested review from
amsiglan,
AWSHurneyt,
bowenlan-amzn,
getsaurabh02,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
lezzago,
sbcd90 and
eirsep
as code owners
|
@MansiShinde thanks! can you run the |
…t-dashboards-plugin into rename-indices-to-indexes
Signed-off-by: Mansi Shinde <[email protected]>
…hinde/index-management-dashboards-plugin into rename-indices-to-indexes
|
Hi @bowenlan-amzn, I ran the "yarn test" command as you suggested and updated the pull request. However, I do not see any test cases being triggered on this PR. Is this due to the WhiteSource Security Check or is this expected behavior? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
=======================================
Coverage 63.37% 63.37%
=======================================
Files 341 341
Lines 11554 11554
Branches 2243 2243
=======================================
Hits 7322 7322
Misses 3658 3658
Partials 574 574 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mansi Shinde <[email protected]>
bowenlan-amzn
approved these changes
Nov 17, 2023
getsaurabh02
approved these changes
Nov 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
* OSCI: rename indices to indexes Signed-off-by: Mansi Shinde <[email protected]> * OSCI: rename indices to indexes Signed-off-by: Mansi Shinde <[email protected]> * update test snapshot Signed-off-by: Mansi Shinde <[email protected]> * updated files based on cypress test result Signed-off-by: Mansi Shinde <[email protected]> --------- Signed-off-by: Mansi Shinde <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]> (cherry picked from commit 03f268d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Nov 17, 2023
* OSCI: rename indices to indexes * OSCI: rename indices to indexes * update test snapshot * updated files based on cypress test result --------- (cherry picked from commit 03f268d) Signed-off-by: Mansi Shinde <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: bowenlan-amzn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename indices to indexes in Index Management UI
Issues Resolved
List any issues this PR will - 637
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.