bug-fix: Restore snapshot shouldn't restore index alias always #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skumawat2025
requested review from
bowenlan-amzn,
Hailong-am,
RamakrishnaChilaka,
vikasvb90 and
SuZhou-Joe
as code owners
skumawat2025
force-pushed
the
snapshot-restore-alias-bug
branch
from
60d0237 to
29a6671
Compare
Signed-off-by: Sandeep Kumawat <[email protected]>
skumawat2025
force-pushed
the
snapshot-restore-alias-bug
branch
from
29a6671 to
625404e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
- Coverage 61.61% 60.96% -0.66%
==========================================
Files 345 347 +2
Lines 12449 12834 +385
Branches 2509 2589 +80
==========================================
+ Hits 7671 7824 +153
- Misses 4075 4271 +196
- Partials 703 739 +36 ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Nov 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> (cherry picked from commit 2d7c80b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 task
skumawat2025
pushed a commit
to skumawat2025/index-management-dashboards-plugin
that referenced
this pull request
Dec 16, 2024
…earch-project#1193) Signed-off-by: Sandeep Kumawat <[email protected]> Co-authored-by: Sandeep Kumawat <[email protected]> (cherry picked from commit 2d7c80b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Sandeep Kumawat <[email protected]>
RamakrishnaChilaka
added a commit
that referenced
this pull request
Dec 16, 2024
#1206) (cherry picked from commit 2d7c80b) Signed-off-by: Sandeep Kumawat <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sandeep Kumawat <[email protected]> Co-authored-by: Ramakrishna Chilaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously restoring a snapshot always tries to restore index alias even if the restore alias is unchecked from the dashboard.
This bug is now being fixed with this PR as we set the checkbox for restore alias as false default option and add a toggle check when users chooses to select alias restore option.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.