Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earlier requests #92

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

jonathanrobie
Copy link
Contributor

These corrections were requested by Joel and Randall about 8 weeks ago in a set of issues. Issuing a pull request to allow them to be examined, modified, or committed more efficiently.

@jdejoode
Copy link
Contributor

Thanks Jonathan, does this PR actually include the previous one? I've been reviewing the previous one, so once that's merged it, could this PR be transformed to only contain what was not covered in the previous one? Thoughts?

@jdejoode
Copy link
Contributor

Would it be possible to provide references to the issues that are covered in this PR (and ditto in the other PR)? That would make it easier to close the issues after the merge.

@jdejoode
Copy link
Contributor

jdejoode commented Sep 1, 2023

Any update here @jonathanrobie? Thanks!

@thesmartwon
Copy link

I'd like to see these changes merged, so I'll answer some of the questions.

Thanks Jonathan, does this PR actually include the previous one?

Yes. You can verify that the SHA (2408955) is the same.

I've been reviewing the previous one, so once that's merged it, could this PR be transformed to only contain what was not covered in the previous one?

That will automatically happen.

Would it be possible to provide references to the issues that are covered in this PR (and ditto in the other PR)?

Together these close #90 .

@jonathanrobie
Copy link
Contributor Author

jonathanrobie commented Jul 23, 2024 via email

@jdejoode jdejoode merged commit 3d15126 into openscriptures:master Aug 27, 2024
@jdejoode
Copy link
Contributor

Thanks @thesmartwon and @jonathanrobie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants