Resolved issue with 'dummy' image to prevent a single build failure f… #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PPathu
force-pushed
the
Version-1.4.Build-Config-File
branch
from
46f6c78 to
640f1c5
Compare
|
@PPathu can you split out the comment in the Python script into a separate commit? It's not related to the current commit message. |
PPathu
force-pushed
the
Version-1.4.Build-Config-File
branch
3 times, most recently
from
c663077 to
4785176
Compare
|
Hey Pratham, can you reword your commits and PR title to be in the imperative mood? i.e. "Add important implementation...", "Resolve issue with...". See https://dev.to/ruanbrandao/how-to-make-good-git-commits-256k |
brianhlin
requested changes
Aug 22, 2024
| @@ -98,7 +101,7 @@ jobs: | |||
| build: | |||
| runs-on: ubuntu-latest | |||
| needs: build-image-list | |||
| if: needs.build-image-list.outputs.images != '["dummy"]' | |||
| if: ${{ needs.build-image-list.outputs.image_list != '["dummy"]' }} | |||
There was a problem hiding this comment.
Suggested change
| if: ${{ needs.build-image-list.outputs.image_list != '["dummy"]' }} | |
| if: ${{ needs.build-image-list.outputs.image_list != 'dummy' }} |
PPathu
force-pushed
the
Version-1.4.Build-Config-File
branch
from
4785176 to
5126b0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a small bug so the 'dummy' image doesn't kill the entire workflow. Also, added an important detail to the comment in the python script.