Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not replace Java record argument annotations with JavaTemplate #4939

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Can not replace Java record argument annotations with JavaTemplate #4939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions rewrite-java-test/src/test/java/org/openrewrite/java/JavaTemplateAnnotationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,58 @@ class A {
)
);
}

@Test
void replacesInRecordVisitor() {
rewriteRun(
spec -> spec.recipe(toRecipe(() -> new JavaIsoVisitor<>() {
@Override
public J.Annotation visitAnnotation(J.Annotation annotation, ExecutionContext p) {
if (annotation.getSimpleName().equals("NotNull")) {
return JavaTemplate.apply("@NonNull", getCursor(), annotation.getCoordinates().replace());
}
return annotation;
}
})),
java(
"""
import org.jetbrains.annotations.NotNull;

public record Person(
@NotNull String firstName,
@NotNull String lastName
) {}
""",
"""
import lombok.NonNull;

public record Person(
@NonNull String firstName,
@NonNull String lastName
) {}
"""));
}

@Test
void replacesInRecord() {
rewriteRun(
spec -> spec.recipe(new ReplaceAnnotation("@org.jetbrains.annotations.NotNull", "@lombok.NonNull", null)),
java(
"""
import org.jetbrains.annotations.NotNull;

public record Person(
@NotNull String firstName,
@NotNull String lastName
) {}
""",
"""
import lombok.NonNull;

public record Person(
@NonNull String firstName,
@NonNull String lastName
) {}
"""));
}
}