Fix and extra tests for literals

[nielsdebruin]

What's changed?

The TabsAndIndentsVisitor cannot correctly handle literals that are not assigned to anything. This PR will fix this behavior and adds extra tests.

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[knutwannheden]

@nielsdebruin On my computer the test_comment_alignment_if_and_return test case fails with this PR. Can you try to confirm?

[nielsdebruin]

@nielsdebruin On my computer the test_comment_alignment_if_and_return test case fails with this PR. Can you try to confirm?

It does, but I believe this problem is also present in main.

[knutwannheden]

Yes, I think so. But with this PR the indent of the return statement is wrong, which I believe isn't the case on main.

[nielsdebruin]

@knutwannheden I ran the test, I see the indentation, but there is not difference between my main, and this branch.

main:

('\n'
 'def my_function(a, b):\n'
 '    if a > b:\n'
 '        # cool\n'
 '        a = b + 1\n'
 '    # cool\n'
 '  return None\n')

This branch:

('\n'
 'def my_function(a, b):\n'
 '    if a > b:\n'
 '        # cool\n'
 '        a = b + 1\n'
 '    # cool\n'
 '  return None\n')

[knutwannheden]

I thought that was working at some point. This definitely needs to be fixed so that we don't produce code that doesn't compile.

[knutwannheden]

I suggest we try to fix that first, independently of this PR, and then we can see how we can merge this PR afterwards.