Make rewrite-maven-plugin search for Kotlin source files in src/*/java if src/*/kotlin does not exist #937
+300
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which fails initially because 0 kotlin source files will be found in the non-existent src/main/kotlin
|
Thanks for the work so far @reisners ! Look forward to the fix. 🙏🏻 |
… for Kotlin sources in src/*/java instead
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Sure first thing tomorrow and hi @reisners |
MBoegers
requested changes
Jan 27, 2025
src/main/java/org/openrewrite/maven/MavenMojoProjectParser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/maven/MavenMojoProjectParser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/maven/MavenMojoProjectParser.java
Outdated
Show resolved
Hide resolved
…otlinTestSourceDir (was kotlinSourceDir)
timtebeek
reviewed
Jan 28, 2025
src/main/java/org/openrewrite/maven/MavenMojoProjectParser.java
Outdated
Show resolved
Hide resolved
…o two independent testcases
|
@reisners Do you have any addition in mind or can we propagate the PR from draft? |
|
I had to answer to one comment from @timtebeek, waiting for feedback. When that is resolved, we good to proceed. |
MBoegers
approved these changes
Jan 28, 2025
|
Thanks both! Great to have these additional source locations covered |
|
Not sure if this is still relevant, but I just ran mvn install locally for
the PR branch. Not sure if that's what you meant me to check though 🤔
…On Tue, Jan 28, 2025 at 6:24 PM Tim te Beek ***@***.***> wrote:
Thanks both! Great to have these additional source locations covered
—
Reply to this email directly, view it on GitHub
<#937 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPKZTQW5DQIVDJSVWXTFLD2M64OPAVCNFSM6AAAAABVXR2OBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJZGYZDSMZYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added an integration test case that verifies that a Kotlin source file under src/main/java was detected and modified by a recipe (Autoformat). This test case initially fails because the rewrite-maven-plugin does not detect Kotlin source files under src/main/java.
What's your motivation?
To demonstrate the issue described in #936
Anything in particular you'd like reviewers to focus on?
I will push the fix in a separate commit.
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist