Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish artifacts to Maven Central #6

Merged
merged 15 commits into from
Dec 18, 2024
Merged

Conversation

wborn
Copy link
Member

@wborn wborn commented Apr 8, 2024

  • Add artifact publishing and signing to Gradle build
  • Add publishing steps to GHA workflow

With these changes GHA will also check if PRs build successfully.

Snapshot artifacts are published to Maven Central (https://s01.oss.sonatype.org/content/repositories/snapshots/io/openremote/) on pushes or workflow dispatches on the main branch.

When a release is created the workflow will publish the artifacts to a staging repository on Maven Central (https://s01.oss.sonatype.org/#stagingRepositories).

@wborn wborn requested a review from richturner April 8, 2024 16:46
@richturner
Copy link
Member

richturner commented Apr 22, 2024

@wborn I had to delete the secrets I added specifically the SIGNING_KEY as it broke the github action (specifically the code that unifies the secrets and inputs it looks like), see here:

https://github.com/openremote/openremote/actions/runs/8662288322/job/23753942442?pr=1289

This will need investigating and likely related to the newline \n characters in the string

Copy link
Member

@richturner richturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See code comments

GenericApp/app/build.gradle Outdated Show resolved Hide resolved
ORLib/build.gradle Outdated Show resolved Hide resolved
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
@wborn wborn merged commit 893daf8 into main Dec 18, 2024
1 check passed
@wborn wborn deleted the feature/release-management branch December 18, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants