Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osm:maxspeed is an URI according to the context #32

Open
hdelva opened this issue Jun 4, 2019 · 4 comments
Open

osm:maxspeed is an URI according to the context #32

hdelva opened this issue Jun 4, 2019 · 4 comments
Labels

Comments

@hdelva
Copy link

hdelva commented Jun 4, 2019

The context currently contains

osm:maxspeed: {
  "@type": "@id"
}

Which doesn't really make sense since it's just a numeric value. We don't need to specify its type at all in the context, the JSON-LD specification does it for us.

@hdelva hdelva added the bug label Jun 4, 2019
@xivk
Copy link
Contributor

xivk commented Jun 4, 2019

Would it be feasible to auto-generate the context? Any thoughts on that?

@akuckartz
Copy link

it's just a numeric value

Is it? Which unit?

@hdelva
Copy link
Author

hdelva commented Jun 5, 2019

All values that make it into a maxspeed property are in km/h, other units such as mp/h get converted. Values such as RO:urban are problematic though, those just disappear at the moment but that should be fixed with #31.

I hope we can find a better solution though. RO:urban feels like something that should get its own URI. So perhaps we can model those as

{
  "@context": {
    "osm": "https://w3id.org/openstreetmap/terms#"
  },
  "@graph": [
    {
      "@id": "some_road",
      "osm:maxspeed": 50
    },
    {
      "@id": "some_other_road",
      "osm:maxspeed": {
        "@id": "osm:RO_urban"
      }
    }
  ] 
}

@xivk
Copy link
Contributor

xivk commented Jun 5, 2019

More information can be found here about RO:urban:

https://wiki.openstreetmap.org/wiki/Key:maxspeed#Values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants