Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a better solution for max speed. #2

Open
xivk opened this issue May 15, 2019 · 3 comments
Open

Figure out a better solution for max speed. #2

xivk opened this issue May 15, 2019 · 3 comments

Comments

@xivk
Copy link
Contributor

xivk commented May 15, 2019

The maxspeed values are now all explicitly defined, this is not sustainable. Perhaps we could have a maxspeed with an explicitly defined 'unit'.

@hdelva
Copy link
Contributor

hdelva commented May 22, 2019

It's not just units though, there are also tags such as maxspeed=RO:urban and maxspeed=signal. I think the only thing we can realistically expect to do with these is to encode them with osm:hasTag. The 'cleanest' way to determine which tags have a well-defined and which ones don't (yet) seems to be a lookup table, unfortunately.

The plan was to create those maxspeed values automatically though, nobody should have to read/write the config file. The code to automate this will probably look like a clump of spaghetti, but at least it's separate from the code that generates the tiles.

@xivk
Copy link
Contributor Author

xivk commented May 23, 2019

Ok, if automating the config file is the way to go we can leaving this as is.

@hdelva
Copy link
Contributor

hdelva commented Jun 13, 2019

I think you had the right idea here actually. The mapping shouldn't be an issue, but we should add the unit. Route planners can use the km/h values just fine, but there are also use cases where the original value and unit are needed - mostly user-facing stuff.

openplannerteam/routable-tiles#32 has a suggestion for a better solution. This might be a breaking change though.

@hdelva hdelva reopened this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants