-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out a better solution for max speed. #2
Comments
It's not just units though, there are also tags such as The plan was to create those maxspeed values automatically though, nobody should have to read/write the config file. The code to automate this will probably look like a clump of spaghetti, but at least it's separate from the code that generates the tiles. |
Ok, if automating the config file is the way to go we can leaving this as is. |
I think you had the right idea here actually. The mapping shouldn't be an issue, but we should add the unit. Route planners can use the km/h values just fine, but there are also use cases where the original value and unit are needed - mostly user-facing stuff. openplannerteam/routable-tiles#32 has a suggestion for a better solution. This might be a breaking change though. |
The maxspeed values are now all explicitly defined, this is not sustainable. Perhaps we could have a maxspeed with an explicitly defined 'unit'.
The text was updated successfully, but these errors were encountered: