Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EA-185 - Remove legacy condition list functionality for emrapi 2.x #226

Merged
merged 1 commit into from
May 23, 2024
Merged

EA-185 - Remove legacy condition list functionality for emrapi 2.x #226

merged 1 commit into from
May 23, 2024

Conversation

mseaton
Copy link
Member

@mseaton mseaton commented May 23, 2024

No description provided.

@mseaton mseaton requested review from mogoodrich, dkayiwa and ibacher May 23, 2024 19:51
mogoodrich
mogoodrich approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@mogoodrich mogoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct, as I believe this is all in core now?

@mseaton mseaton merged commit 6e9ed6c into master May 23, 2024
1 check passed
@mseaton mseaton deleted the EA-185 branch May 23, 2024 22:03
@ibacher
Copy link
Member

ibacher commented May 24, 2024

I actually seem to recall that there was some additional logic I left in saveCondition() in core to continue supporting this endpoint, so it may be that there's actually more code we can dispense with eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogoodrich mogoodrich mogoodrich approved these changes

@dkayiwa dkayiwa dkayiwa approved these changes

@ibacher ibacher Awaiting requested review from ibacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mseaton @ibacher @mogoodrich @dkayiwa