Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EA-181: Relax EMR API dependency on Metadata Sharing #222

Merged
merged 1 commit into from
Mar 7, 2024
Merged

EA-181: Relax EMR API dependency on Metadata Sharing #222

merged 1 commit into from
Mar 7, 2024

Conversation

mogoodrich
Copy link
Member

No description provided.

@mogoodrich mogoodrich requested review from mseaton and dkayiwa March 7, 2024 19:12
mseaton
mseaton approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@mseaton mseaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you have tested this and find that it still works as expected with MDS and also starts up and works without errors without MDS, looks good to me. Not sure why we didn't do this 10 years ago if so.

@dkayiwa dkayiwa merged commit 14460b2 into master Mar 7, 2024
1 check passed
@mogoodrich
Copy link
Member Author

Thanks @dkayiwa and @mseaton !

@mogoodrich
Copy link
Member Author

FWIW @mseaton I didn't test that the deprecated MDS functionality in the module still worked, but I don't see why it wouldn't...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkayiwa dkayiwa dkayiwa approved these changes

@mseaton mseaton mseaton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mogoodrich @mseaton @dkayiwa