Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add french translation #93

Closed
wants to merge 4 commits into from
Closed

Conversation

azizdiakite
Copy link

@azizdiakite azizdiakite commented Oct 1, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

https://openmrs.atlassian.net/browse/O3-4041

Screenshots

Related Issue

Other

Copy link
Contributor

@reagan-meant reagan-meant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @azizdiakite

Comment on lines 1 to +66
"declinedStatus": "REFUSÉ",
"discard": "Abandonner",
"errorMarkingOrderFulfillStatus": "Une erreur est survenue lors de la mise à jour du statut de la demande",
"errorPickingAnOrder": "Erreur lors de la sélection de la demande",
"errorRejectingRequest": "Erreur lors du rejet de la demande ",
"errorUpdatingEncounter": "Une erreur est survenue lors de la mise à jour des résultats des tests",
"exceptionStatus": "EXCEPTION",
"filterOrdersByStatus": "Filter orders by status",
"fulfillerComment": "Fulfiller Comment",
"generateSuccessfully": "You have successfully updated test results",
"inProgress": "In progress",
"inProgressStatus": "IN_PROGRESS",
"filterOrdersByStatus": "Filtrer les demandes par statut",
"fulfillerComment": "Commentaire du responsable",
"generateSuccessfully": "Vous avez mis à jour les résultats des tests avec succès",
"inProgress": "En cours",
"inProgressStatus": "EN_COURS",
"instructions": "Instructions",
"laboratory": "Laboratory",
"labResultsForm": "Lab Results Form",
"laboratory": "Laboratoire",
"labResultsForm": "Formulaire de résultats de laboratoire",
"loading": "Chargement",
"markOrderFulfillStatus": "Test order completed",
"newStatus": "NEW",
"nextPage": "Next page",
"noLabRequestsFoundCheckFilters": "No lab requests found. Please check your filters and try again.",
"onHoldStatus": "ON_HOLD",
"onOrAfterDateFilter": "Filter orders on or after : ",
"option": "Choose an Option",
"orderer": "orderer",
"orderNumber": "Order Number",
"orderPickedSuccessfully": "You have successfully picked an order",
"orders": "Orders",
"markOrderFulfillStatus": "Demande de test terminée",
"newStatus": "NOUVEAU",
"nextPage": "Page suivante",
"noLabRequestsFoundCheckFilters": "Aucune demande d'analyse trouvée. Veuillez vérifier vos filtres et réessayer.",
"onHoldStatus": "EN_ATTENTE",
"onOrAfterDateFilter": "Filtrer les demandes à partir de :",
"option": "Choisissez une option",
"orderer": "Prescripteur",
"orderNumber": "Numéro de la demande",
"orderPickedSuccessfully": "Vous avez sélectionné une demande avec succès",
"orders": "Demandes",
"patient": "Patient",
"pickedAnOrder": "Picked an order",
"pickRequest": "Pick Lab Request",
"pickRequestConfirmationText": "Continuing will update the request status to \"In Progress\" and advance it to the next stage. Are you sure you want to proceed?",
"pickupLabRequest": "Pickup Lab Request",
"previousPage": "Previous page",
"procedure": "procedure",
"receivedStatus": "RECEIVED",
"reject": "Reject",
"rejectLabRequest": "Reject Lab Request",
"rejectLabRequestSuccessMessage": "",
"rejectLabRequestTitle": "Lab Request Rejected",
"results": "Results",
"save": "Save",
"searchThisList": "Search this list",
"status": "Status",
"tabletOverlay": "Tablet overlay",
"testOrderCompletedSuccessfully": "You have successfully completed the test order",
"testsOrdered": "Tests ordered",
"testType": "Test Type",
"totalorders": "Total Orders",
"updateEncounter": "Update lab results",
"urgency": "Urgency",
"view": "View ",
"worklist": "Ex-Worklist"
"pickedAnOrder": "Demande sélectionnée",
"pickRequest": "Sélectionner la demande de laboratoire",
"pickRequestConfirmationText": "Continuer mettra à jour le statut de la demande à \"En cours\" et la fera avancer à l'étape suivante. Êtes-vous sûr de vouloir continuer?",
"pickupLabRequest": "Sélectionner la demande",
"previousPage": "Page précédente",
"procedure": "Procédure",
"receivedStatus": "REÇU",
"reject": "Rejeter",
"rejectLabRequest": "Rejeter la demande",
"rejectLabRequestSuccessMessage": "Demande d'analyse rejetée avec succès",
"rejectLabRequestTitle": "Demande d'analyse rejetée",
"results": "Résultats",
"save": "Enregistrer",
"searchThisList": "Rechercher dans la liste",
"status": "Statut",
"tabletOverlay": "Prise de plusieurs médicaments",
"testOrderCompletedSuccessfully": "Vous avez terminé la demande de test avec succès",
"testsOrdered": "Demandes d'analyses",
"testType": "Type de test",
"totalorders": "Total des demandes",
"updateEncounter": "Mettre à jour les résultats d'analyse",
"urgency": "Urgence",
"view": "Voir",
"worklist": "Analyses en cours",
"noLabRequestsFoundC": "Aucune demande d'analyse trouvée",
"checkFilters": "Veuillez vérifier les filtres ci-dessus et réessayer",
"startDate":"Date de début",
"endDate":"Date de fin",
"totalOrders":"Total des demandes",
"itemsPerPage": "Éléments par page"
Copy link
Member

@denniskigen denniskigen Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a stab at this, @azizdiakite!

So, we don't modify non-en translation files by hand. Instead, we use the Transifex integration for that. These strings ought to be translated via the Transifex UI. Automated PRs will then provide the updated strings back to the repo (similar to this one).

Read more about this here.

Comment on lines 18 to 20
createHomeDashboardLink({
name: 'laboratory',
slot: 'laboratory-dashboard-slot',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the canonical way to translate the dashboard link text:

Suggested change
createHomeDashboardLink({
name: 'laboratory',
slot: 'laboratory-dashboard-slot',
// t('laboratory', 'Laboratory')
createHomeDashboardLink({
name: 'laboratory',
slot: 'laboratory-dashboard-slot',
title: 'Laboratory'

@@ -24,7 +26,7 @@ function DashboardExtension({ dashboardLinkConfig }: { dashboardLinkConfig: Dash
to={`${spaBasePath}/${name}`}
className={`cds--side-nav__link ${navLink.match(name) && 'active-left-nav-link'}`}
>
{title}
{t(title, 'Laboratory')}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{t(title, 'Laboratory')}
{t(title)}

@ibacher ibacher closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants