Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Various tooling updates and tweaks #104

Merged
merged 2 commits into from
Dec 6, 2024
Merged

(chore) Various tooling updates and tweaks #104

merged 2 commits into from
Dec 6, 2024

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Dec 5, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR introduces several improvements to our tooling setup including:

  • Standardized ESLint Configuration: Aligns the ESLint configuration with the standards used in other O3 repositories for consistency.
  • Pre-commit Hook Enhancements: Separates linting and formatting tasks in the pre-commit hook to adhere to best practices, ensuring clearer and more efficient code checks.
  • Version Updates: Updates core tooling versions, including Turbo and Yarn, to leverage the latest features and improvements.
  • Refactoring: A significant portion of the code changes are due to refactoring necessary to address violations of React's rules of hooks, as identified by the ESLint React Hooks plugin.

Screenshots

Related Issue

Other

@denniskigen
(chore) Various tooling updates and tweaks
4710404 
This PR introduces several improvements to our tooling setup including:

- Standardized ESLint Configuration: Aligns the ESLint configuration with the standards used in other O3 repositories for consistency.
- Pre-commit Hook Enhancements: Separates linting and formatting tasks in the pre-commit hook to adhere to best practices, ensuring clearer and more efficient code checks.
- Version Updates: Updates core tooling versions, including Turbo and Yarn, to leverage the latest features and improvements.
- Refactoring: A significant portion of the code changes are due to refactoring necessary to address violations of React's rules of hooks, as identified by the ESLint React Hooks plugin.
@jwnasambu
Copy link
Contributor

L.G.T.M

NethmiRodrigo
NethmiRodrigo approved these changes Dec 6, 2024
View reviewed changes
Copy link

@NethmiRodrigo NethmiRodrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @denniskigen!

@denniskigen denniskigen merged commit af5aa26 into main Dec 6, 2024
6 checks passed
@denniskigen denniskigen deleted the chore/tooling branch December 6, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NethmiRodrigo NethmiRodrigo NethmiRodrigo approved these changes

@samuelmale samuelmale samuelmale approved these changes

@jabahum jabahum Awaiting requested review from jabahum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denniskigen @jwnasambu @samuelmale @NethmiRodrigo