Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-3816 Add tab for rejected orders and prevent further actions on De… #102

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

CynthiaKamau
Copy link
Contributor

…clined Tests

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Add tab for rejected orders and prevent further actions on declined Tests

Screenshots

Screen.Recording.2024-11-28.at.11.45.01.mov

Related Issue

Other

@ojwanganto
Copy link
Contributor

Thanks, @CynthiaKamau. It would be worthy to show the reason for declining the order

Copy link
Member

@donaldkibet donaldkibet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CynthiaKamau

Comment on lines +55 to +58
export const declinedLabRequestsTable = getAsyncLifecycle(
() => import('./lab-tabs/data-table-extensions/declined-lab-requests-table-extension'),
options,
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export const declinedLabRequestsTable = getAsyncLifecycle(
() => import('./lab-tabs/data-table-extensions/declined-lab-requests-table-extension'),
options,
);
import DeclinedLabRequstTable from './lab-tabs/data-table-extensions/declined-lab-requests-table-extension';
export const declinedLabRequestsTable = getSyncLifecycle(DeclinedLabRequstTable,options);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this in line with how the other tabs have been exported

@CynthiaKamau
Copy link
Contributor Author

Thanks, @CynthiaKamau. It would be worthy to show the reason for declining the order

I have added it as part of the expansion slot

@jabahum
Copy link
Collaborator

jabahum commented Dec 4, 2024

@CynthiaKamau lets fix conflicts

@CynthiaKamau
Copy link
Contributor Author

@CynthiaKamau lets fix conflicts

Done

@pirupius pirupius merged commit 47004c0 into main Dec 16, 2024
6 checks passed
@pirupius pirupius deleted the O3-3816 branch December 16, 2024 10:04
denniskigen added a commit that referenced this pull request Dec 18, 2024
Restores the state of the order details table to a state prior to the changes made in #102. This will likely require a
review of the changes made in that PR to ensure that everything is working as expected.
@denniskigen denniskigen mentioned this pull request Dec 18, 2024
3 tasks
ibacher pushed a commit that referenced this pull request Dec 18, 2024
Restores the state of the order details table to a state prior to the changes made in #102. This will likely require a
review of the changes made in that PR to ensure that everything is working as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants