Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually Black format everything #3223

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

MicahGale
Copy link
Contributor

@MicahGale MicahGale commented Dec 13, 2024

Description

This is a follow-on to #3222 that actually formats everything with black.

Proposed way to merge.

  1. Review and approve Laid out infrastructure for switching to black formatting all code. #3222.
  2. Run black locally on develop and then compare with this PR. I think this is the only way to verify nothing was snuck in with so many changes.
  3. This will lead to a lot of merge conflicts for all open PRs. I would recommend that those with open PRs:
    1. Run black against their branch and commit.
    2. Merge in develop. This should eliminate almost all merge conflicts.

Fixes #2002 (actually implement.)

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coding style for Python
1 participant