Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write and read mesh name attribute #3221

Merged
merged 11 commits into from
Dec 16, 2024
Merged

Conversation

pshriwise
Copy link
Contributor

Description

@shimwell aptly noted that user-specified names for Mesh objects are present in the Python API, but aren't written to XML or HDF5. This PR addresses that problem. There's also some refactoring so that common object information I/O occurs in the base classes on both the Python and C++ to reduce code duplication.

Some tests have been added to make sure this data is round-tripped properly to and from the XML and HDF5 formats.

Fixes #3213

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@pshriwise pshriwise requested a review from shimwell December 13, 2024 21:38
Copy link
Member

@shimwell shimwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solved the issue nicely, many thanks Patrick. If there are no objections let us merge this in on Monday

@shimwell shimwell merged commit 775c415 into openmc-dev:develop Dec 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mesh name not appearing in mesh from statepoint file
2 participants