Fix[SMT]: Update rs code for error in live_resize_memory #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanHQF
approved these changes
Mar 13, 2024
|
@lionriver pls solve the CI error according to the details. |
zhshuj
reviewed
Mar 13, 2024
zvmsdk/returncode.py
Outdated
| 16: ("Failed to start the guest: '%(userid)s', %(msg)s") | ||
| 16: ("Failed to start the guest: '%(userid)s', %(msg)s"), | ||
| 17: ("Failed to live resize memory of guest: '%(userid)s', " | ||
| "error: failed to update the memory size: '%(err)s'.") |
There was a problem hiding this comment.
Let's change the error reason to be more precise.
"error: failed to update the memory size: '%(err)s'.")
==>
"error: chmem command failed: '%(err)s'.")
|
@lionriver please fix the DCO (I think you need sign the PR) , thanks |
Signed-off-by: LI XiaoDong <[email protected]>
zhshuj
approved these changes
Mar 15, 2024
bjhuangr
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
z/VM: Fail to resize memory, but the error message wrongly reports
fail to resize CPU.Changes for fix:
change
rscode for error inlive_resize_memory:7==>17(newly defined for memory error)