ISSUE #85 : Base64-Encoder Executable #93
+495
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A utility for base64 encoding and decoding of model and model-driver parameter files. This biary executable will be used for compiling shared-libraries of model and model-driver. This utility will be installed in the CMAKE_INSTALL_RELOC_BINDIR.
Specify build and installation instructions for kim_base64_encode. kim_base64_encode is a critical dependant for building model/model-driver shared-libraries. kim_base64_encode must be built before kim-api. kim_base64_encode will be installed in the CMAKE_INSTALL_RELOC_BINDIR for system-wide access during compile-time of model/model-driver shared-libraries.
…ible now. Stylistic changes: base64.hpp moved to KIM_Base64.hpp KIM_Base64.hpp edited to have 2 space indent Function names/variable names to follow PascalCase or camelCase (like other KIM-API files) Doxygen style docstrings TODO: Licensing issue discussion with Ryan
This is a work in progress and the code is not expected to compile at this stage. A number of small changes have been made to port the code from c++11 to c++98. A pending change is to replace the string-literals with escaped characters.
Create the command-line-interface for kim-base64-encode following the docopt.org format keeping inline with other utils/kim-api-* binary executables
|
@nav-mohan I think the Open suse error stems from the fact that it is using newer OpenSUSE with newer libasan, so now |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #93 +/- ##
==========================================
+ Coverage 45.29% 45.96% +0.67%
==========================================
Files 140 142 +2
Lines 13059 13279 +220
Branches 1338 1352 +14
==========================================
+ Hits 5915 6104 +189
- Misses 6476 6501 +25
- Partials 668 674 +6 ☔ View full report in Codecov by Sentry. |
yafshar
reviewed
Jan 22, 2025
Comment on lines
+4
to
+8
| `base64-encode` is a simple xxd replacement to convert files | ||
| into embeddable C++ source code. Instead of using binary array | ||
| it used base64 strings, which makes it much more performant | ||
| for large files. Currently only -i option is supported for | ||
| compatibility. More options to be released in future. C++ 98 compliant. |
There was a problem hiding this comment.
Suggested change
| `base64-encode` is a simple xxd replacement to convert files | |
| into embeddable C++ source code. Instead of using binary array | |
| it used base64 strings, which makes it much more performant | |
| for large files. Currently only -i option is supported for | |
| compatibility. More options to be released in future. C++ 98 compliant. | |
| `base64-encode` is a straightforward replacement for xxd, | |
| designed to convert files into embeddable C++ source code. | |
| Unlike binary arrays, it utilizes base64 strings, significantly | |
| enhancing performance for large files. Currently, only the -i | |
| option is supported for compatibility, with more options | |
| planned for future releases. It is compliant with C++98 standards. |
This will enable the "Run Workflow" button for our Github Actions on the Github Web Interface.
The Fortran compiler was not included in the installation of mingw-w64-x86_64-toolchain. It must be explicitly installed through mingw-w64-x86_64-gcc-fortran
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #85
Currently, we use
xxdand a nativecmakeimplementation to encode parameter files for linking into a shared-library.base64-encodeis an executable meant to replace both.It will be installed in the
CMAKE_INSTALL_RELOC_BINDIR.