Support for large parameter size using Base 64 encoding #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build kim_base64_encode
A utility for base64 encoding and decoding of model and model-driver parameter files. This biary executable will be used for compiling shared-libraries of model and model-driver. This utility will be installed in the CMAKE_INSTALL_RELOC_BINDIR.
Specify build and installation instructions for kim_base64_encode. kim_base64_encode is a critical dependant for building model/model-driver shared-libraries. kim_base64_encode must be built before kim-api. kim_base64_encode will be installed in the CMAKE_INSTALL_RELOC_BINDIR for system-wide access during compile-time of model/model-driver shared-libraries.
Commits: kim-base64-encode and associated decoder for moving KIM-API towards base64 encoding, instead of binary xxd
…ible now. Stylistic changes: base64.hpp moved to KIM_Base64.hpp KIM_Base64.hpp edited to have 2 space indent Function names/variable names to follow PascalCase or camelCase (like other KIM-API files) Doxygen style docstrings TODO: Licensing issue discussion with Ryan
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 45.29% 46.25% +0.96%
==========================================
Files 140 142 +2
Lines 13059 13298 +239
Branches 1338 1354 +16
==========================================
+ Hits 5915 6151 +236
- Misses 6476 6497 +21
+ Partials 668 650 -18 ☔ View full report in Codecov by Sentry. |
|
Please rebase on the devel branch and submit as a pull request based on that not the master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
KIM_Base64.hpp for Base64 encoder-decoder class
utils/KIM_Base64Encoder.cpp: for kim-base64-encoder, xxd replacement
Edited:
CMakelists.txt: Compile and install base64 encoder, defaults to Release
item-macros.cmake.in: move from xxd to base64 encoder, remove Cmake based xxd workaround
KIM_SharedLibrary.cpp: decode base64 string before writing to hard drive.
TODO:
Licensing discussion: Base64 encoder is heavily borrowed from Boost, which is permitted like MIT but need separate inclusion of the license, for the included file. See: KIM_Base64.hpp for more info
New KIM-API is source compatible with older version, but not binary-compatible.