8343846: [lworld] implement spec changes to stack map tables #1333
Conversation
|
👋 Welcome back vromero! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
|
|
| /** | ||
| * {@return the expanded unset fields} | ||
| */ | ||
| List<Integer> unSetFields(); |
There was a problem hiding this comment.
Use List<NameAndTypeEntry> please
| */ | ||
| public static StackMapFrameInfo of(Label target, | ||
| List<VerificationTypeInfo> locals, | ||
| List<VerificationTypeInfo> stack) { | ||
| List<VerificationTypeInfo> stack, | ||
| List<Integer> unSetFields) { |
There was a problem hiding this comment.
Can keep the original one untouched for compatibility and add a new factory ofUnsetFields(List<NameAndTypeEntry>)
| @@ -572,7 +572,7 @@ public void write(Attribute<?> a, CodeAttribute lr) { | |||
| int offsetDelta = lr.labelToBci(frame.target()) - lastOffset - 1; | |||
| switch (frameType) { | |||
| case 247 -> { | |||
There was a problem hiding this comment.
Should print the assert unset here
still experimental
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1333/head:pull/1333$ git checkout pull/1333Update a local copy of the PR:
$ git checkout pull/1333$ git pull https://git.openjdk.org/valhalla.git pull/1333/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1333View PR using the GUI difftool:
$ git pr show -t 1333Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1333.diff