You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add APINote and javadoc for IdentityException where it will be useful to know that identity or value objects are treated differently.
Simplified WeakHashMap javadoc updates for IdentityException.
Added note to System.identityHashCode to include value objects.
Added to class javadoc for IdentityHashMap for value objects.
Progress
Change must not contain extraneous whitespace
Integration blocker
⚠️ Title mismatch between PR and JBS for issue JDK-8346307
Issue
JDK-8346307: Clarify identity vs value in Class, Objects, and document limitations of value objects (Bug - P4) ⚠️ Title mismatch between PR and JBS.
…IdentityException
Add APINote and javadoc for IdentityException where it will be useful to know.
Simplified WeakHashMap javadoc updates for IdentityException.
Added note to System.identityHashCode to include value objects.
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
…IdentityException
Add APINote and javadoc for IdentityException where it will be useful to know.
Updated Objects.hasIdentity to return true for non-null reference to identity class; else false
Added Objects.isValueObject to return true for non-null reference to value class; else false
Updated tests for value objects.
⚠️@RogerRiggs This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).
RogerRiggs
changed the title
8346307: [lworld] Document WeakHashMap and other apis that may throw IdentityException
8346307: [lworld] Clarify identity vs value in Class, Objects, and document limitations of value objects
Jan 13, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RogerRiggs
changed the title
Add APINote and javadoc for IdentityException where it will be useful to know that identity or value objects are treated differently.
Simplified WeakHashMap javadoc updates for IdentityException.
Added note to System.identityHashCode to include value objects.
Added to class javadoc for IdentityHashMap for value objects.
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1327/head:pull/1327$ git checkout pull/1327Update a local copy of the PR:
$ git checkout pull/1327$ git pull https://git.openjdk.org/valhalla.git pull/1327/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1327View PR using the GUI difftool:
$ git pr show -t 1327Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1327.diff
Using Webrev
Link to Webrev Comment