-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8349: JMC Copyright year and some http links require update #626
Conversation
👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into |
@Suchitainf This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/integrate |
Going to push as commit ff9adf5. |
@Suchitainf Pushed as commit ff9adf5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
As part of our accessibility testing we have found that copyright year mentioned in JMC is still 2022 at many places which should be updated to 2025.
The copyright link which is attached to copyright footer of Help pages, is also not working as its still following older HTTP link. We need to update that link to HTTPS.
There are few HTTP links also which are in help page which should be updated to HTTPS.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/626/head:pull/626
$ git checkout pull/626
Update a local copy of the PR:
$ git checkout pull/626
$ git pull https://git.openjdk.org/jmc.git pull/626/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 626
View PR using the GUI difftool:
$ git pr show -t 626
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/626.diff
Using Webrev
Link to Webrev Comment