Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8349: JMC Copyright year and some http links require update #626

Closed
wants to merge 5 commits into from

Conversation

Suchitainf
Copy link
Collaborator

@Suchitainf Suchitainf commented Jan 29, 2025

As part of our accessibility testing we have found that copyright year mentioned in JMC is still 2022 at many places which should be updated to 2025.

The copyright link which is attached to copyright footer of Help pages,  is also not working as its still following older HTTP link. We need to update that link to HTTPS.

There are few HTTP links also which are in help page which should be updated to HTTPS.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8349: JMC Copyright year and some http links require update (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/626/head:pull/626
$ git checkout pull/626

Update a local copy of the PR:
$ git checkout pull/626
$ git pull https://git.openjdk.org/jmc.git pull/626/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 626

View PR using the GUI difftool:
$ git pr show -t 626

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/626.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2025

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 29, 2025

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349: JMC Copyright year and some http links require update

Reviewed-by: vpurnam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr label Jan 29, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2025

Webrevs

Copy link
Collaborator

@viragpurnam viragpurnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready label Jan 31, 2025
@Suchitainf
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 31, 2025

Going to push as commit ff9adf5.

@openjdk openjdk bot added the integrated label Jan 31, 2025
@openjdk openjdk bot closed this Jan 31, 2025
@openjdk
Copy link

openjdk bot commented Jan 31, 2025

@Suchitainf Pushed as commit ff9adf5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants