Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297: Update OptionsCheckRule for new JDK releases #625

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ky0n
Copy link
Contributor

@ky0n ky0n commented Jan 18, 2025

New cli-options were added for JDK release 22, 23 based on the official release notes (removed part and deprecated path)
https://www.oracle.com/java/technologies/javase/22-relnote-issues.html
https://www.oracle.com/java/technologies/javase/23-relnote-issues.html

I also updated existing depcrecated options in the array based on
this file in the jdk https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/arguments.cpp#L516 which is regularly updated, i switched between git tags to find earlier options when they were part of the array. I did this to jdk10, but not before jdk version 10 for everything i could find. I can also update the arguments, which were obsoleted in jdk9.

Any feedback appreciated, thank you.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8297: Update OptionsCheckRule for new JDK releases (Task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/625/head:pull/625
$ git checkout pull/625

Update a local copy of the PR:
$ git checkout pull/625
$ git pull https://git.openjdk.org/jmc.git pull/625/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 625

View PR using the GUI difftool:
$ git pr show -t 625

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/625.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2025

👋 Welcome back ky0n! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr label Jan 18, 2025
@ky0n ky0n changed the title 8297: OptionsCheckRule jvm arguments 8297: Update OptionsCheckRule for new JDK releases Jan 18, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 18, 2025

Webrevs

@thegreystone thegreystone requested a review from Gunde January 19, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant