Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343224: print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4 #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jan 2, 2025

Hi all,

This pull request contains a backport of commit b3e63631 from the openjdk/jdk repository.

The commit being backported was authored by GennadiyKrivoshein on 28 Dec 2024 and was reviewed by Alexander Zvegintsev, Alexander Scherbatiy, Prasanta Sadhukhan and Alisen Chung.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8343224 needs maintainer approval

Issue

  • JDK-8343224: print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4 (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/11/head:pull/11
$ git checkout pull/11

Update a local copy of the PR:
$ git checkout pull/11
$ git pull https://git.openjdk.org/jdk24u.git pull/11/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11

View PR using the GUI difftool:
$ git pr show -t 11

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/11.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 2, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b3e63631c735862ba00270636b4ef51c0e48a1af 8343224: print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4 Jan 2, 2025
@openjdk
Copy link

openjdk bot commented Jan 2, 2025

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review January 29, 2025 00:26
@openjdk
Copy link

openjdk bot commented Jan 29, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 29, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2025

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant