8346887: DrawFocusRect() may cause an assertion failure

[satyenme]

Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• JDK-8346887 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8346887: DrawFocusRect() may cause an assertion failure (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/233/head:pull/233
$ git checkout pull/233

Update a local copy of the PR:
$ git checkout pull/233
$ git pull https://git.openjdk.org/jdk23u.git pull/233/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 233

View PR using the GUI difftool:
$ git pr show -t 233

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/233.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (0db2b921)

[satyenme]

/approval request for backport. Minor change that adds an additional check before an assertion for windows. Tested with tier1, tier2, and GHA tests. Risk is low.

[openjdk]

@satyenme
8346887: The approval request has been created successfully.

[GoeLin]

Hi @satyenme, what about jdk24?
Best regards, Goetz.

[satyenme]

Hi @GoeLin,

This should be the corresponding PR for JDK 24: openjdk/jdk24u#14 (integrated yesterday).

Thanks,
Satyen