Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Credential Offer example to use credential_configuration_ids instead of credentials #353

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

deshmukhrajvardhan
Copy link
Contributor

Closes #348

Copy link
Contributor

@jogu jogu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rajvardhan! LGTM.

@deshmukhrajvardhan
Copy link
Contributor Author

Thanks Joseph! I'll go ahead and merge

@deshmukhrajvardhan deshmukhrajvardhan merged commit d5ed198 into main Jun 21, 2024
2 checks passed
@deshmukhrajvardhan deshmukhrajvardhan deleted the 348-credential-configuration-ids-example branch June 21, 2024 17:34
@Sakurann
Copy link
Collaborator

@deshmukhrajvardhan we'll go over it in the next wg call, but it's only chairs who merge the PRs, and usually we require more than 3 approvals and wait minimum for a week before merging PRs. thank you.

@deshmukhrajvardhan
Copy link
Contributor Author

Oops sorry about that @Sakurann

Let me know how I can help untangle this mistake.

For future scenarios would it be a good idea to have these guidelines pop up during PR creation?

E.g.
Can we create a PR template with these guidelines?
https://docs.github.com/en/[email protected]/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

@Sakurann
Copy link
Collaborator

@deshmukhrajvardhan the chairs decided not to revert the PR this time, so all good - thank you for doing the PR. Yes, we will consider creating a template with the guidelines - thank you for the suggestion.

@deshmukhrajvardhan
Copy link
Contributor Author

Thanks @Sakurann .
If needed I can volunteer to work on the template with guidelines.

@Sakurann
Copy link
Collaborator

@deshmukhrajvardhan that would be great! would be happy to review if you could start drafting a template.

@deshmukhrajvardhan
Copy link
Contributor Author

@Sakurann Here is a draft PR for it :)
#363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Previously defined parameter credentials is used in the example in 4.1.2.
3 participants