Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify this is an editor's draft in the title #126

Merged
merged 1 commit into from
Dec 7, 2023
Merged

clarify this is an editor's draft in the title #126

merged 1 commit into from
Dec 7, 2023

Conversation

Sakurann
Copy link
Collaborator

solves issue #125

selfissued
selfissued approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@selfissued selfissued left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. It's good that you also updated the version number.

If we're going to do this, I suggest that we should also do this for SIOPv2 and OpenID4VP, so that we're consistent.

@Sakurann Sakurann merged commit 9a5e26c into main Dec 7, 2023
2 checks passed
@Sakurann
Copy link
Collaborator Author

Sakurann commented Dec 7, 2023 •
edited
Loading

If we're going to do this, I suggest that we should also do this for SIOPv2 and OpenID4VP, so that we're consistent.

if @paulbastian can open issues in OpenID4VP and SIOP repos, we can do similar PRs there too.

This was referenced Dec 7, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbastian paulbastian paulbastian approved these changes

@tplooker tplooker tplooker approved these changes

@c2bo c2bo c2bo approved these changes

@selfissued selfissued selfissued approved these changes

@jogu jogu jogu approved these changes

@tlodderstedt tlodderstedt Awaiting requested review from tlodderstedt

@Macke Macke Awaiting requested review from Macke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Sakurann @jogu @selfissued @c2bo @tplooker @paulbastian