Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support HTTP Accept-Language in the request for Credential Issuer Metadata to request a subset for display data #116

Merged
merged 6 commits into from
Dec 7, 2023
Merged

support HTTP Accept-Language in the request for Credential Issuer Metadata to request a subset for display data #116

merged 6 commits into from
Dec 7, 2023

Conversation

paulbastian
Copy link
Contributor

Closes #84

@paulbastian paulbastian linked an issue Nov 17, 2023 that may be closed by this pull request
Use HTTP Accept-Language Header to request Issuer Metadata #84
Closed
@paulbastian paulbastian requested review from c2bo and Sakurann November 17, 2023 16:37
jogu
jogu requested changes Nov 23, 2023
View reviewed changes
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
paulbastian and others added 2 commits November 24, 2023 17:55
@paulbastian @peppelinux
Apply suggestions from code review
74f3f76 
Co-authored-by: Giuseppe De Marco <[email protected]>
@paulbastian @peppelinux
Apply suggestions from code review
fd9ccb1 
Co-authored-by: Giuseppe De Marco <[email protected]>
Sakurann
Sakurann reviewed Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@Sakurann Sakurann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving assuming my proposed changes are accepted.

@Sakurann Sakurann added this to the ID-1 milestone Dec 7, 2023
@paulbastian paulbastian requested a review from jogu December 7, 2023 09:45
@paulbastian
Copy link
Contributor Author

ready for merge in my view, all issues resolved

@Sakurann Sakurann merged commit 843b77b into main Dec 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sakurann Sakurann Sakurann approved these changes

@c2bo c2bo c2bo approved these changes

@peppelinux peppelinux peppelinux approved these changes

@jogu jogu jogu approved these changes

@danielfett danielfett Awaiting requested review from danielfett

@tlodderstedt tlodderstedt Awaiting requested review from tlodderstedt

@pmhsfelix pmhsfelix Awaiting requested review from pmhsfelix

@selfissued selfissued Awaiting requested review from selfissued

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ID-1
Development

Successfully merging this pull request may close these issues.

Use HTTP Accept-Language Header to request Issuer Metadata
6 participants
@paulbastian @jogu @pmhsfelix @peppelinux @c2bo @Sakurann