Google Assistant: Renamed "Secondary User Verification" parameters #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eiko Wagenknecht <[email protected]>
Job #94: Bundle Size — 10.46MB (~+0.01%).Changed metrics (2/8)
|
|
@michikrug @eikowagenknecht can this be merged now? |
Yes |
ghys
approved these changes
May 9, 2021
ghys
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to put this into yet another PR, but I just received word from @michikrug that these parameters should be renamed for better consistency, the old ones are deprecated.
openhab/openhab-google-assistant#196 (comment)
About the timing of this: Apparently it needs to go live at the same time the new GA binding goes live, so maybe synchronizing with @michikrug is a good idea before merging this.
Signed-off-by: Eiko Wagenknecht [email protected]