Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten issues traced to JS audio #8253

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

danoli3
Copy link
Member

@danoli3 danoli3 commented Jan 14, 2025

It's always been working with new libs ...

Problem was the JS Audio

Disabled and works:
image

Yay:
image

@danoli3
Copy link
Member Author

danoli3 commented Jan 14, 2025

Merging this Audio Disable to look at Audio Worklet instead:
#7727

@Jonathhhan is that ready to add in?

@danoli3
Copy link
Member Author

danoli3 commented Jan 14, 2025

Fixes: #8211

Fixes: #8219

@danoli3 danoli3 self-assigned this Jan 14, 2025
@danoli3 danoli3 added this to the 0.12.1 milestone Jan 14, 2025
@danoli3
Copy link
Member Author

danoli3 commented Jan 14, 2025

Merging as fixes compile issues.

Disables Audio - Todo merge #7727 / will fetch and rebase myself

@danoli3 danoli3 merged commit cd463ee into openframeworks:master Jan 14, 2025
15 checks passed
@Jonathhhan
Copy link
Contributor

@danoli3 Very nice. Courious to know what broke it. Regarding my audioWorklets PR: It is ready to merge, the issue is with CORS and that USE_PTHREADS need to be enabled (which is still a reason to use ScriptNodeProcessor - if working).

@danoli3
Copy link
Member Author

danoli3 commented Jan 14, 2025

With -pthread -matomics should solve that. CISP stuff is forced an issue regardless of CORS now.

modified .htaccess with some variables should fix this and template now is split for js / css which allows md5 and fixes rest of CORS loading issues. As long as its on the same domain

@Jonathhhan
Copy link
Contributor

Jonathhhan commented Jan 14, 2025

@ofTheo
Copy link
Member

ofTheo commented Jan 14, 2025

Wow - mad props for tracking this down @danoli3 !!

One of the big issues is that (I think) emrun isn't using apache so .htaccess CORS solution doesn't work locally ( I think ) and definitely doesn't for ngnix web servers. Does .htaccess work for you with emrun?

Our main priority should be easy of use for people running locally and then some clear instructions on how to upload and host.

As @Jonathhhan mentioned before pthreads was triggering the cors restrictions, if you are able to get it working with pthreads that's great and we can switch to worklet based approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants