-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emscripten issues traced to JS audio #8253
Conversation
Merging this Audio Disable to look at Audio Worklet instead: @Jonathhhan is that ready to add in? |
Merging as fixes compile issues. Disables Audio - Todo merge #7727 / will fetch and rebase myself |
@danoli3 Very nice. Courious to know what broke it. Regarding my audioWorklets PR: It is ready to merge, the issue is with CORS and that USE_PTHREADS need to be enabled (which is still a reason to use ScriptNodeProcessor - if working). |
With modified .htaccess with some variables should fix this and template now is split for js / css which allows md5 and fixes rest of CORS loading issues. As long as its on the same domain |
@danoli3 this is my newest audioWorklet branch: https://github.com/Jonathhhan/openFrameworks/tree/emscripten_3.1.57_audioWorklet |
Wow - mad props for tracking this down @danoli3 !! One of the big issues is that (I think) emrun isn't using apache so Our main priority should be easy of use for people running locally and then some clear instructions on how to upload and host. As @Jonathhhan mentioned before pthreads was triggering the cors restrictions, if you are able to get it working with pthreads that's great and we can switch to worklet based approach. |
It's always been working with new libs ...
Problem was the JS Audio
Disabled and works:
Yay: