Core small changes #7952
Merged
Core small changes #7952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofTheo
reviewed
May 16, 2024
libs/openFrameworks/gl/ofTexture.cpp
Outdated
| GLfloat offsetw = 0.0f; | ||
| GLfloat offseth = 0.0f; | ||
| GLfloat offsetw { 0.0f }; | ||
| GLfloat offseth { 0.0f }; |
There was a problem hiding this comment.
hmm - I am really not super in favor of introducing this pattern across the whole core.
If it is for optimization I wouldn't bother as the compiler will do the optimization for you.
There was a problem hiding this comment.
Agreed! I'll be reverting back this simple ones.
It makes sense only sometimes, like creating a shared_ptr, or a more complex object at once, to avoid an extra copy
ofTheo
reviewed
May 16, 2024
ofTheo
reviewed
May 16, 2024
libs/openFrameworks/gl/ofTexture.cpp
Outdated
| auto topLeft = getCoordFromPoint(sx, sy); | ||
| auto bottomRight = getCoordFromPoint(sx + sw, sy + sh); | ||
| auto topLeft { getCoordFromPoint(sx, sy) }; | ||
| auto bottomRight { getCoordFromPoint(sx + sw, sy + sh) }; |
There was a problem hiding this comment.
again, just feels unnecessary vs: auto topLeft = getCoordFromPoint(sx, sy);
danoli3
added a commit
to danoli3/openFrameworks
that referenced
this pull request
May 20, 2024
…leedingmacOS * commit '7f37e70f65e9e022ba8868fb555570ce2c78a6ba': (37 commits) Allows Retina hi res enabled via App or Project.xcconfig (openframeworks#7971) actions changes (openframeworks#7968) Changing exr to hdr files for compatability with windows (openframeworks#7964) ofMesh - newfaces push_back to insert a list (openframeworks#7772) restore default-copy-constructibility of ofEvent (openframeworks#7969) [actions] ccache update (openframeworks#7967) Core small changes (openframeworks#7952) config.emscripten.default.mk for Emscripten >= 3.1.52 (openframeworks#7909) Fix edge case in findDelimiter (openframeworks#7911) oscpack / udpSocket: invert the "break_" semaphore (openframeworks#7963) ofxOscMessage: extra implicit adds [fixes something noted through openframeworks#7938 debugging] (openframeworks#7953) #changelog #ofxOsc ofThreadChannel::clear() to clear the channel (openframeworks#7921) #changelog #threadChannel OfxOscReceiver: from detach() to join() (openframeworks#7949) Update ofMathConstants.h (openframeworks#7958) [actions] update ubuntu 24.04 (openframeworks#7955) ofScopedMatrix (openframeworks#7946) [actions] - testing one action with multiple jobs for tests (openframeworks#7860) adding of.entitlements and vscode files to gitignore (openframeworks#7031) Make - use relative paths (openframeworks#7519) FPS timing with chrono (openframeworks#7867) ... # Conflicts: # libs/openFrameworks/sound/ofAVEngineSoundPlayer.mm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.