Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update experimental tag on examples, tests #1150

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mattwthompson
Copy link
Member

Description

With the 0.4.0 release, some methods are no longer "experimental" but many tests were not updated and INTERCHANGE_EXPERIMENTAL=1 was unnecessarily set.

This change also moves around an example that's no longer "experimental" into the root directory, which is needed for discovery in the docs automation: openforcefield/openff-docs#71

Checklist

  • Add tests
  • Lint
  • Update docstrings

@mattwthompson mattwthompson force-pushed the move-experimental-examples branch from c0c0264 to 7fa3c0d Compare January 23, 2025 17:47
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (4edb63a) to head (576b2b6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1150   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files          70       70           
  Lines        6028     6028           
=======================================
  Hits         5629     5629           
  Misses        399      399           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattwthompson mattwthompson marked this pull request as ready for review January 23, 2025 17:56
@mattwthompson
Copy link
Member Author

As this intersects with how openff-docs discovers examples, I think @Yoshanuikabundi is the best person to reason through these changes - particularly the example(s) moving around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant