-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some assets out of webpacker #10690
base: master
Are you sure you want to change the base?
Move some assets out of webpacker #10690
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
FYI @jibees I wanted to get a better understanding of how this all works, so decided to have a go at moving images and fonts out of webpack. |
eef8300
to
e866547
Compare
3911631
to
2ffae75
Compare
@dacook Should this be closed or moved out of 'in dev' and into 'tech debt prioritised'? |
I think this is still required for #10298, but obviously I haven't been actively working on it sorry. So I will move to tech debt prioritised. |
Work in progress. There are still some errors loading fonts:
Also conflicts to resolve. |
What? Why?
As Maikel suggested:
I think we shouldn't need images or fonts to be loaded by webpack. This will simplify the transition away from webpack.
What should we test?
This reverts some of #7784
So similar to that, test that fonts and images load...
Release notes
Changelog Category: User facing changes | Technical changes
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates