Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some assets out of webpacker #10690

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dacook
Copy link
Member

@dacook dacook commented Apr 13, 2023

What? Why?

As Maikel suggested:

I think we shouldn't need images or fonts to be loaded by webpack. This will simplify the transition away from webpack.

What should we test?

This reverts some of #7784

So similar to that, test that fonts and images load...

Release notes

Changelog Category: User facing changes | Technical changes

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@dacook

This comment was marked as resolved.

@dacook dacook self-assigned this Apr 13, 2023
@dacook
Copy link
Member Author

dacook commented Apr 13, 2023

FYI @jibees I wanted to get a better understanding of how this all works, so decided to have a go at moving images and fonts out of webpack.

@dacook dacook force-pushed the 10298-move-assets-out-of-webpacker branch from eef8300 to e866547 Compare April 13, 2023 07:20
@jibees
Copy link
Contributor

jibees commented Apr 13, 2023

FYI @jibees I wanted to get a better understanding of how this all works, so decided to have a go at moving images and fonts out of webpack.

I think it's the right move. I wanted to do everything at once with PR #10652, but i'm not sure this is the way to go.
Then: thanks!!!

@dacook dacook force-pushed the 10298-move-assets-out-of-webpacker branch from 3911631 to 2ffae75 Compare April 14, 2023 08:03
@lin-d-hop
Copy link
Contributor

@dacook Should this be closed or moved out of 'in dev' and into 'tech debt prioritised'?

@dacook
Copy link
Member Author

dacook commented Jun 28, 2023

I think this is still required for #10298, but obviously I haven't been actively working on it sorry. So I will move to tech debt prioritised.

@dacook
Copy link
Member Author

dacook commented Jun 28, 2023

Work in progress. There are still some errors loading fonts:

No route matches [GET] "/fonts/fontawesome-webfont.woff"

Also conflicts to resolve.

@dacook dacook removed their assignment Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: All the things 💤
Development

Successfully merging this pull request may close these issues.

3 participants