-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Search facets #103
feat: Search facets #103
Conversation
138a517
to
c85b23f
Compare
Cool! It would be nice to have a "Apply new filters" button that appears below the facets, as it's not intuitive that we need to click on the search button again to apply them. |
- labels_tags | ||
- ecoscore_grade | ||
- nova_groups | ||
- ecoscore_grade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ecoscore_grade is already there, nutriscore maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to remove that, this is not useful any more… now it's the interface that requests facets (more logical).
Co-authored-by: Pierre Slamich <[email protected]>
Yes, in another PR ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me
frontend/src/search-facets.ts
Outdated
} else { | ||
return html``; // FIXME: is this ok ? | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What this comment highlight ?
If the return html'' render nothing ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was not sure when I code, now it seems ok, I will remove the FIXME :-)
It's possible to updates results when you check any filter |
I personally don't like it much because it makes it hard to select two filters at once… |
Limitations:
facets-demo.mp4