Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify Price.currency validation #67

Merged
merged 2 commits into from
Nov 27, 2023
Merged

feat: simplify Price.currency validation #67

merged 2 commits into from
Nov 27, 2023

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Nov 25, 2023

What

Improve the Price.currency field

  • stop using the sqlachemy_utils CurrencyType
  • use instead a simple Enum generate from babel
  • all the possible values are now visible in the schema

Screenshot

image

@raphodn raphodn self-assigned this Nov 25, 2023
@raphodn raphodn requested a review from raphael0202 November 25, 2023 14:16
@raphael0202 raphael0202 merged commit d7dfb0c into main Nov 27, 2023
5 checks passed
@raphael0202 raphael0202 deleted the raphodn/schema-currency-simplify branch November 27, 2023 08:47
@github-actions github-actions bot mentioned this pull request Nov 27, 2023
Merged
@raphodn raphodn changed the title feat: simply Price.currency validation feat: simplify Price.currency validation Nov 27, 2023
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphael0202 raphael0202 raphael0202 approved these changes

Assignees

@raphodn raphodn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphodn @raphael0202