feat: add CORS configuration #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael0202
reviewed
Nov 23, 2023
app/config.py
Outdated
| @@ -36,6 +36,7 @@ class Settings(BaseSettings): | |||
| postgres_password: str | |||
| postgres_host: str | |||
| postgres_port: int = 5432 | |||
| cors_allow_origins: list = [] | |||
There was a problem hiding this comment.
shouldn't you use a Field with a default factory here?
https://docs.pydantic.dev/latest/concepts/fields/#default-values
And you can use list[str]
There was a problem hiding this comment.
yes you're right, I fixed it here : 0fa085b
this helped : https://docs.pydantic.dev/latest/concepts/pydantic_settings/
There was a problem hiding this comment.
not yet a pro of these typings in python ^^
raphael0202
approved these changes
Nov 23, 2023
raphodn
force-pushed
the
raphodn/add-cors
branch
from
0fa085b to
06b8470
Compare
Closed
raphodn
added a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://fastapi.tiangolo.com/tutorial/cors/
app.py.env