Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: listen to updates from Product Opener using Redis #618

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

raphael0202
Copy link
Contributor

Just like Robotoff does.

@raphael0202 raphael0202 merged commit 9e4d326 into main Dec 11, 2024
8 checks passed
@raphael0202 raphael0202 deleted the redis-update branch December 11, 2024 16:37
@@ -35,3 +35,20 @@ services:
scheduler:
<<: *api-base
command: ["python", "manage.py", "qcluster"]

update-listener:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. does this mean we can disable the cron tasks that daily sync the whole DB ? or should we have both running for a while ?
  2. does redis send us changes from all flavors ?

Copy link
Contributor Author

@raphael0202 raphael0202 Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean we can disable the cron tasks that daily sync the whole DB ? or should we have both running for a while ?

I prefer having both running for a while

does redis send us changes from all flavors ?

It should, but here again we should make sure it works well in prod before disabling the daily dump import

@raphodn raphodn linked an issue Dec 11, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Product sync: use OFF's Redis stream to get live updates
2 participants