Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve Product schema (inherit, field description) #58

Merged
merged 4 commits into from
Nov 23, 2023
Merged

feat: improve Product schema (inherit, field description) #58

merged 4 commits into from
Nov 23, 2023

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Nov 23, 2023

What

  • inherit ProductBase from ProductCreate (avoids duplicating the code field)
  • add description to all Product fields

@raphodn raphodn self-assigned this Nov 23, 2023
@raphodn raphodn requested a review from raphael0202 November 23, 2023 09:36
@raphodn raphodn mentioned this pull request Nov 23, 2023
Merged
@raphael0202 raphael0202 merged commit 1fa567e into main Nov 23, 2023
3 of 4 checks passed
@raphael0202 raphael0202 deleted the raphodn/product-schema-improvements branch November 23, 2023 09:48
@raphodn raphodn mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphael0202 raphael0202 raphael0202 approved these changes

Assignees

@raphodn raphodn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphodn @raphael0202