feat: simple Location model #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
raphodn
force-pushed
the
raphodn/location-model
branch
from
0a2cb4b to
9752066
Compare
raphael0202
reviewed
Nov 20, 2023
| class Location(Base): | ||
| id = Column(Integer, primary_key=True, index=True) | ||
|
|
||
| osm_id = Column(BigInteger) |
There was a problem hiding this comment.
why don't we use osm_id as a primary key directly, as it's an INT?
There was a problem hiding this comment.
I'd rather not rely 100% on OSM. There's probably future locations that will not/never be in OSM. Like online stores, or temporary markets, or even closed locations 🤔...
raphael0202
reviewed
Nov 20, 2023
raphael0202
reviewed
Nov 20, 2023
raphael0202
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Locationmodel & schema