feat: add advanced filtering on GET /prices #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael0202
reviewed
Nov 15, 2023
app/crud.py
Outdated
| @@ -50,26 +50,18 @@ def delete_user(db: Session, user_id: UserBase): | |||
| return False | |||
|
|
|||
|
|
|||
| def get_prices(db: Session, filters={}): | |||
| def get_prices(db: Session, filters: PriceFilter = None): | |||
There was a problem hiding this comment.
PricerFilter | None = None
raphodn
force-pushed
the
raphodn/price-get-with-advanced-filters
branch
from
99f7e02 to
d645667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot